-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation topic 1 #25
Conversation
…llowing the professor's feedback
What do you mean by "Apart from being in GitHub the system will have an API responsible of handling the questions generated previously from WikiData."? |
There was missinng a coma, now fixed. Those are two requirements, the first one is that it will be stored and deployed via GitHub, and the second, is two draw more emphasis on the present of the two APIs, ours and the WikiData one. The WikiData one is used by us to generate the questions, and our API is used to send those questions to the game. |
I dont think your descriptions are 100% accurate "The system will also store the historical data of the users, thanks to the login and registering service featured in the application, and users will be able to access their information. The application will have at least English as an available language. Moreover, the project will be stored and deployed through GitHub. If you want to reference that questions generated through wikidata will be passed to our application it is not done thorugh an API it is done through an interface that connects the question generation and the game. I have referenced in the text the apis that need to be public based on the lab description document. I would suggest to put the text that I have rephrased instead of yours or discuss its final shape from it. |
First of all, I believe the text you suggested is pretty good and I've no problem replacing the original one with it. However, I believe taht one of us is not fully graping the requirements of the aplication, since it explicitly states that the information about the question must be passed through an API.
I understand that requirement as the need of our own API for communicating the questions, not simply an interface. If you have understand it in another way, please explain it to me so we can either reach a conclusion, or pospone it until monday and discuss it with the professor. |
Upon rereading your last comment I've realize that the last line in the paragraph already speaks about the use of the API. My apologies for the misunderstanding. |
No worries |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consider the changes to be correct
Fixed the problems detected in the review